Skip to content

Conversation

@jeroenjanssen-cpp
Copy link

Which problem is this PR solving?

  • instrumentation-runtime-node README.md has wrong links pointing to instrumenation-pg

Short description of the changes

  • this corrects the links in the instrumentation-runtime-node README.md

@jeroenjanssen-cpp jeroenjanssen-cpp requested a review from a team as a code owner November 17, 2024 08:51
@linux-foundation-easycla
Copy link

CLA Not Signed

@jeroenjanssen-cpp jeroenjanssen-cpp changed the title Update instrumentation-runtime-node README.md docs: Update instrumentation-runtime-node README.md Nov 17, 2024
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

You need to sign the CLA, before we are able to merge this. Follow the steps from the comment above, and you will be able to get it signed. 😄

@jeroenjanssen-cpp
Copy link
Author

Sorry, I didn't figure out up front how to CLA signing works from my company pov. (even though this is a small change)
so I am getting that sorted out

@maryliag
Copy link
Contributor

Np, you can also sign as an individual, not as part of a company.

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (5eb61d8) to head (b74a525).
Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-luna
Copy link
Contributor

@jeroenjanssen-cpp have you signed the CLA? If so I can run the CI again :)

@blumamir
Copy link
Member

Hi @jeroenjanssen-cpp
Thank you for contributing this fix.

Are you still interested in finalizing this PR, or should we close it?

@maryliag
Copy link
Contributor

Solved by #2786

@maryliag maryliag closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants