-
Notifications
You must be signed in to change notification settings - Fork 620
chore(instr-koa): update instrumentation-koa tests #2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instr-koa): update instrumentation-koa tests #2566
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
=======================================
Hits 7277 7277
Misses 741 741 |
|
|
||
| it('should work with ESM usage', async () => { | ||
| const itFn = isrouterCompat ? it : it.skip; | ||
| itFn('should work with ESM usage', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious: does this.skip() not work in async test functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.skip() does unfortunately not work when using a lambda function. I've started using
it('does thing', function() {
...
});in all new tests for that reason. Unfortunately we lambdas it across all tests in both repos, so it'd be very difficult to change it everywhere.
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Which problem is this PR solving?
Fixes: #2564
Short description of the changes
@koa/routertests if version is not compatible with nodejs version