Skip to content

Conversation

@david-luna
Copy link
Contributor

Which problem is this PR solving?

Fixes: #2564

Short description of the changes

  • skip @koa/router tests if version is not compatible with nodejs version

@david-luna david-luna requested a review from a team as a code owner November 28, 2024 12:08
@github-actions github-actions bot added pkg:instrumentation-koa pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Nov 28, 2024
@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (97ebd4f) to head (8706abf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           


it('should work with ESM usage', async () => {
const itFn = isrouterCompat ? it : it.skip;
itFn('should work with ESM usage', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: does this.skip() not work in async test functions?

Copy link
Member

@pichlermarc pichlermarc Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.skip() does unfortunately not work when using a lambda function. I've started using

it('does thing', function() {
...
});

in all new tests for that reason. Unfortunately we lambdas it across all tests in both repos, so it'd be very difficult to change it everywhere.

@github-actions
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@david-luna david-luna enabled auto-merge (squash) December 2, 2024 14:50
@david-luna david-luna merged commit bf8117e into open-telemetry:main Dec 2, 2024
3 checks passed
@david-luna david-luna deleted the 2564-koa-router-tests branch April 15, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:instrumentation-koa pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(instr-koa) Update tests for @koa/router v13

3 participants