Skip to content

Conversation

@pichlermarc
Copy link
Member

Supersedes #2225 - has some changes to it though:

  • cucumber did not have node types pinned, so the build failed
  • nestjs instrumentation was missing a dependency that was required for tests to run properly

@github-actions github-actions bot added pkg:instrumentation-nestjs-core pkg:instrumentation-cucumber pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Dec 6, 2024
@pichlermarc pichlermarc added the dependencies Pull requests that update a dependency file label Dec 6, 2024
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (2e0cbdf) to head (9270e11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
- Coverage   90.80%   90.75%   -0.05%     
==========================================
  Files         169      169              
  Lines        8026     8026              
  Branches     1635     1635              
==========================================
- Hits         7288     7284       -4     
- Misses        738      742       +4     

see 1 file with indirect coverage changes

@trentm
Copy link
Contributor

trentm commented Dec 6, 2024

Nice work.


Some other versions of @types/node that I see.

├─┬ @opentelemetry/[email protected] -> ./plugins/node/opentelemetry-instrumentation-fastify
│ └── @types/[email protected]
├─┬ @opentelemetry/[email protected] -> ./propagators/propagator-aws-xray-lambda
│ └── @types/[email protected]
├─┬ @opentelemetry/[email protected] -> ./propagators/propagator-aws-xray
│ └── @types/[email protected] deduped

Those are older than the "blessed" version "18.18.14". Perhaps that's fine then.

@trentm
Copy link
Contributor

trentm commented Dec 6, 2024

  • nestjs instrumentation was missing a dependency that was required for tests to run properly

Hrm, perhaps I broke that in this PR ~7w ago then: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2464/files#diff-5bd19fcb42c8adf472fa8ddceb76b947ab770bbb899a1cacc40dbf4aaa138531L2

@trentm
Copy link
Contributor

trentm commented Dec 7, 2024

Something is up wth the runner for TAV for PR / tav / Run test-all-versions (22) (pull_request). It has been almost 2h running so far.

@trentm trentm merged commit 30d668e into open-telemetry:main Dec 7, 2024
25 checks passed
@pichlermarc pichlermarc deleted the renovate/lock-file-maintenance branch December 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pkg:auto-configuration-propagators pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:browser-extension-autoinjection pkg:contrib-test-utils pkg:host-metrics pkg:id-generator-aws-xray pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-kafkajs pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:plugin-react-load pkg:propagation-utils pkg:propagator-aws-xray pkg:propagator-aws-xray-lambda pkg:propagator-instana pkg:propagator-ot-trace pkg:redis-common pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-docker pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg:sampler-aws-xray pkg:sql-common pkg:test-utils pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants