Skip to content

Conversation

@onurtemizkan
Copy link
Member

Which problem is this PR solving?

Resolves: #2442

  • TBD

Short description of the changes

  • TBD

@onurtemizkan onurtemizkan force-pushed the express-middleware-span-termination branch 2 times, most recently from db5cf13 to 0d93cf6 Compare December 13, 2024 16:24
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (3350583) to head (687c821).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
- Coverage   90.79%   90.79%   -0.01%     
==========================================
  Files         169      169              
  Lines        8059     8057       -2     
  Branches     1645     1644       -1     
==========================================
- Hits         7317     7315       -2     
  Misses        742      742              
Files with missing lines Coverage Δ
...try-instrumentation-express/src/instrumentation.ts 98.56% <100.00%> (-0.03%) ⬇️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@onurtemizkan onurtemizkan force-pushed the express-middleware-span-termination branch 3 times, most recently from 96051a4 to 4d9084b Compare January 10, 2025 10:01
@onurtemizkan
Copy link
Member Author

Closing as looks like it is being superseded by #2638

@onurtemizkan onurtemizkan deleted the express-middleware-span-termination branch January 13, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:propagation-utils pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-instana pkg:sampler-aws-xray pkg:test-utils pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

express instrumentation - span end prematurely for non-middleware instrumentations