Skip to content

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 10, 2025

Which problem is this PR solving?

Short description of the changes

  • Removes dependency on type from JS SDK v2 devDependency.

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (3dfc7e3) to head (45cdfc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2639   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8059     8059           
  Branches     1645     1645           
=======================================
  Hits         7317     7317           
  Misses        742      742           
Files with missing lines Coverage Δ
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (ø)

@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label Jan 13, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving since this PR is approved by owners)

@pichlermarc pichlermarc merged commit bda9632 into open-telemetry:main Jan 15, 2025
25 checks passed
@trivikr trivikr deleted the aws-sdk-types-sqs branch January 15, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants