Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

Ownership of the instrumentation is moving to https://github.com/fastify/otel. Fastify will provide and maintain an official instrumentation (@fastify/otel) going forward.

See #2647

Short description of the changes

This PR deprecates @opentelemetry/instrumentation-fastify (once merged, I will follow up with deprecation on npm)

@pichlermarc pichlermarc added pkg:instrumentation-fastify has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions labels Jan 16, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner January 16, 2025 15:44
@github-actions github-actions bot added the pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. label Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (45c55a6) to head (bc1c14b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2651   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         172      172           
  Lines        8137     8137           
  Branches     1649     1649           
=======================================
  Hits         7402     7402           
  Misses        735      735           
Files with missing lines Coverage Δ
...try-instrumentation-fastify/src/instrumentation.ts 95.38% <ø> (ø)

@Eomm Eomm mentioned this pull request Jan 25, 2025
2 tasks
@pichlermarc pichlermarc enabled auto-merge (squash) January 27, 2025 11:39
@pichlermarc pichlermarc merged commit fcca38a into open-telemetry:main Jan 27, 2025
4 checks passed
AbhiPrasad added a commit to getsentry/sentry-javascript that referenced this pull request Feb 24, 2025
The main thing this change does is to upgrade all the packages to use
https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.57.1

Other changes include:
- Knex instrumentation bug fix:
open-telemetry/opentelemetry-js-contrib#2650
- Fastify deprecation:
open-telemetry/opentelemetry-js-contrib#2651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-fastify pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants