-
Notifications
You must be signed in to change notification settings - Fork 620
chore: add scripts/gen-semconv-ts.js to help generate semconv.ts files for unstable semconv consts #2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: add scripts/gen-semconv-ts.js to help generate semconv.ts files for unstable semconv consts #2669
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4dede11
chore: add scripts/gen-semconv-ts.js to help generate semconv.ts file…
trentm 4f80e77
remove some cruft from this script
trentm 6d64bb9
Merge branch 'main' into tm-gen-semconv-ts
trentm 629f255
if no unstable semconv usages found, then don't write a src/semconv.t…
trentm c058095
update the script to use *typescript* sources to copy from, rather th…
trentm 3484f6e
Merge branch 'main' into tm-gen-semconv-ts
trentm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,217 @@ | ||
| #!/usr/bin/env node | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * Generate a "src/semconv.ts" in the current workspace dir, which includes | ||
| * copies of the unstable semconv definitions used in this package. | ||
| * | ||
| * This is to support the recommendation from | ||
| * https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv | ||
| * that any usage of unstable Semantic Conventions definitions should be done | ||
| * by *copying* those definitions to a local file in this package. | ||
| * | ||
| * Usage: | ||
| * node scripts/gen-semconv-ts.js [WORKSPACE-DIR] | ||
| */ | ||
|
|
||
| const fs = require('fs'); | ||
| const { execSync } = require('child_process'); | ||
| const path = require('path'); | ||
| const { globSync } = require('glob'); | ||
|
|
||
| const USE_COLOR = process.stdout.isTTY && !process.env.NO_COLOR?.length > 0; | ||
|
|
||
| let numWarns = 0; | ||
| function warn(...args) { | ||
| numWarns += 1; | ||
| if (USE_COLOR) { | ||
| process.stdout.write('\x1b[31m'); | ||
| } | ||
| process.stdout.write('gen-semconv-ts warning: '); | ||
| if (USE_COLOR) { | ||
| process.stdout.write('\x1b[39m'); | ||
| } | ||
| console.log(...args); | ||
| } | ||
|
|
||
| function getAllWorkspaceDirs() { | ||
| const pj = JSON.parse( | ||
| fs.readFileSync(path.join(TOP, 'package.json'), 'utf8') | ||
| ); | ||
| return pj.workspaces | ||
| .map((wsGlob) => globSync(path.join(wsGlob, 'package.json'))) | ||
| .flat() | ||
| .map(path.dirname); | ||
| } | ||
|
|
||
| function lintSemconvDeps() { | ||
| const wsDirs = getAllWorkspaceDirs(); | ||
|
|
||
| for (let wsDir of wsDirs) { | ||
| const pj = JSON.parse( | ||
| fs.readFileSync(path.join(wsDir, 'package.json'), 'utf8') | ||
| ); | ||
| const depRange = pj?.dependencies?.[SEMCONV]; | ||
| const devDepRange = pj?.devDependencies?.[SEMCONV]; | ||
| if (!(depRange || devDepRange)) { | ||
| continue; | ||
| } | ||
|
|
||
| // Rule: The semconv dep should *not* be pinned. Expect `^X.Y.Z`. | ||
| const pinnedVerRe = /^\d+\.\d+\.\d+$/; | ||
| if (depRange && pinnedVerRe.exec(depRange)) { | ||
| problem(`${wsDir}/package.json: package ${pj.name} pins "${SEMCONV}" in dependencies, but should not (see https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#why-not-pin-the-version)`); | ||
| } else if (devDepRange && pinnedVerRe.exec(devDepRange)) { | ||
| problem(`${wsDir}/package.json: package ${pj.name} pins "${SEMCONV}" in devDependencies, but should not (see https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#why-not-pin-the-version)`); | ||
| } | ||
|
|
||
| // Rule: The incubating entry-point should not be used. | ||
| const srcFiles = globSync(path.join(wsDir, 'src', '**', '*.ts')); | ||
| const usesIncubatingRe = /import\s+\{?[^{;]*\s+from\s+'@opentelemetry\/semantic-conventions\/incubating'/s; | ||
| for (let srcFile of srcFiles) { | ||
| const srcText = fs.readFileSync(srcFile, 'utf8'); | ||
| const match = usesIncubatingRe.exec(srcText); | ||
| if (match) { | ||
| problem(`${srcFile}: uses the 'incubating' entry-point from '@opentelemetry/semantic-conventions', but should not (see https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv)`) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function genSemconvTs(wsDir) { | ||
| const semconvPath = require.resolve('@opentelemetry/semantic-conventions', | ||
| {paths: [path.join(wsDir, 'node_modules')]}); | ||
| const semconvStable = require(semconvPath); | ||
|
|
||
| // Gather unstable semconv imports. Consider any imports from | ||
| // '@opentelemetry/semantic-conventions/incubating' or from an existing local | ||
| // '.../semconv'. | ||
| const srcFiles = globSync(path.join(wsDir, '{src,test}', '**', '*.ts')); | ||
| const importRes = [ | ||
| /import\s+{([^}]*)}\s+from\s+'@opentelemetry\/semantic-conventions\/incubating'/s, | ||
| /import\s+{([^}]*)}\s+from\s+'\.[^']*\/semconv'/s, | ||
| ]; | ||
| const names = new Set(); | ||
| for (const srcFile of srcFiles) { | ||
| const srcText = fs.readFileSync(srcFile, 'utf8'); | ||
| for (const importRe of importRes) { | ||
| const match = importRe.exec(srcText); | ||
| if (match) { | ||
| match[1].trim().split(/,/g).forEach(n => { | ||
| n = n.trim(); | ||
| if (n) { | ||
| if (semconvStable[n]) { | ||
| warn(`${wsDir}/${srcFile}: '${n}' export is available on the stable "@opentelemetry/semantic-conventions" entry-point. This definition will not be included in the generated semconv.ts. Instead use:\n import { ${n} } from '@opentelemetry/semantic-conventions';`) | ||
| } else { | ||
| names.add(n); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| if (names.size === 0) { | ||
| console.log(`Did not find any usage of unstable semconv exports in "${wsDir}/{src,test}/**/*.ts".`) | ||
| } else { | ||
| console.log(`Found import of ${names.size} unstable semconv definitions.`) | ||
| } | ||
|
|
||
| // Load the source from the semconv package from which we'll copy. | ||
| // We are cheating a bit in knowing the semconv package structure. We want | ||
| // "build/esnext/experimental_*.js" files. Use the "esnext" build because it | ||
| // is closed to the TypeScript we want. | ||
| const semconvEsnextDir = path.resolve( | ||
| semconvPath, | ||
| '../../esnext', // .../build/src/index.js -> .../build/esnext | ||
| ); | ||
| const srcPaths = globSync(path.join(semconvEsnextDir, 'experimental_*.js')); | ||
| const src = srcPaths | ||
| .map(f => fs.readFileSync(f)) | ||
| .join('\n\n'); | ||
|
|
||
| const sortedNames = Array.from(names).sort(); | ||
| const chunks = []; | ||
| for (let name of sortedNames) { | ||
| const re = new RegExp(`^export const ${name} = .*;$`, 'm') | ||
| const match = re.exec(src); | ||
| if (!match) { | ||
| throw new Error(`could not find "${name}" export in semconv build files: ${re} did not match in content from ${srcPaths.join(', ')}`); | ||
| } | ||
|
|
||
| // Find a preceding block comment, if any. | ||
| const WHITESPACE_CHARS = [' ', '\t', '\n', '\r']; | ||
| let idx = match.index - 1; | ||
| while (idx >=1 && WHITESPACE_CHARS.includes(src[idx])) { | ||
| idx--; | ||
| } | ||
| if (src.slice(idx-1, idx+1) !== '*/') { | ||
| // There is not a block comment preceding the export. | ||
| chunks.push(match[0]); | ||
| continue; | ||
| } | ||
| idx -= 2; | ||
| while (idx >= 0) { | ||
| if (src[idx] === '/' && src[idx+1] === '*') { | ||
| // Found the start of the block comment. | ||
| chunks.push(src.slice(idx, match.index) + match[0]); | ||
| break; | ||
| } | ||
| idx--; | ||
| } | ||
| } | ||
|
|
||
| const semconvTsPath = path.join(wsDir, 'src', 'semconv.ts'); | ||
| fs.writeFileSync( | ||
| semconvTsPath, | ||
| `/* | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /* | ||
| * This file contains a copy of unstable semantic convention definitions | ||
| * used by this package. | ||
| * @see https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv | ||
| */ | ||
|
|
||
| ${chunks.join('\n\n')} | ||
| `, | ||
| { encoding: 'utf8' } | ||
| ); | ||
| console.log(`Generated "${semconvTsPath}".`); | ||
|
|
||
| console.log(`Running 'npx eslint --fix src/semconv.ts' to fix formatting.`); | ||
| execSync(`npx eslint --fix src/semconv.ts`, { cwd: wsDir }); | ||
| } | ||
|
|
||
| // mainline | ||
| const wsDir = process.argv[2] || '.'; | ||
| genSemconvTs(wsDir); | ||
| if (numWarns > 0) { | ||
| process.exitCode = 1; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.