test(instrumentation-winston): Include all versions in coverage #2684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
winston/all-versions-coverage
branch
from
330dddf to
28f4df0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2684 +/- ##
==========================================
- Coverage 92.41% 91.52% -0.90%
==========================================
Files 171 171
Lines 8150 8150
Branches 1653 1653
==========================================
- Hits 7532 7459 -73
- Misses 618 691 +73 |
blumamir
approved these changes
Feb 12, 2025
Member
blumamir
left a comment
blumamir
left a comment
There was a problem hiding this comment.
Thank you for adding this.
LGTM
6 tasks
deejay1
pushed a commit
to deejay1/opentelemetry-js-contrib
that referenced
this pull request
Apr 14, 2025
…-telemetry#2684) Co-authored-by: Marc Pichler <[email protected]> Co-authored-by: Amir Blum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
v1tov2andv3tests in the test command to make sure they are included in the coverage report