Skip to content

Conversation

@blumamir
Copy link
Member

Following #2717 , I noticed that all the packages in the repo use mocha from the mono-repo root package.json except for @opentelemetry/instrumentation-runtime-node which is the only one that specify the dependency explicitly.

This PR remove this dependency to align this package with the repo and reduce the modules we need to pull into node_modules

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (197ee04) to head (168360d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2731   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         171      171           
  Lines        8150     8150           
  Branches     1653     1653           
=======================================
  Hits         7455     7455           
  Misses        695      695           

Copy link
Member

@d4nyll d4nyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blumamir!

@blumamir blumamir merged commit b947650 into open-telemetry:main Feb 26, 2025
25 checks passed
deejay1 pushed a commit to deejay1/opentelemetry-js-contrib that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants