Skip to content

feat(instrumentation-kafkajs)!: add .tav.yml and narrow support range to (>=0.3.0 <3) #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 9 commits into from
Mar 19, 2025
Merged

feat(instrumentation-kafkajs)!: add .tav.yml and narrow support range to (>=0.3.0 <3) #2758

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3a68b25
chore: add .tav.yml for testing multiple KafkaJS versions
AvihuHenya Mar 17, 2025
13b7435
chore: add test-all-versions script to package.json
AvihuHenya Mar 17, 2025
6a519c2
fix: update version support in instrumentation.ts for KafkaJS
AvihuHenya Mar 17, 2025
50d0416
Merge branch 'main' into kafkajs-tav-file
AvihuHenya Mar 17, 2025
ed21e0d
fix: update version support in README for KafkaJS
AvihuHenya Mar 18, 2025
c6f9a6c
Merge remote-tracking branch 'upstream/main' into kafkajs-tav-file
AvihuHenya Mar 18, 2025
1bed596
Merge branch 'main' into kafkajs-tav-file
AvihuHenya Mar 18, 2025
eb250cd
Merge branch 'main' into kafkajs-tav-file
pichlermarc Mar 18, 2025
34ef474
Merge branch 'main' into kafkajs-tav-file
pichlermarc Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugins/node/instrumentation-kafkajs/.tav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kafkajs:
- versions:
include: ">=0.3.0 <3"
mode: latest-minors
commands: npm run test
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-kafkajs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-kafkajs

### Supported versions

- [`kafkajs`](https://www.npmjs.com/package/kafkajs) versions `>=0.1.0 <3`
- [`kafkajs`](https://www.npmjs.com/package/kafkajs) versions `>=0.3.0 <3`

## Usage

Expand Down
2 changes: 2 additions & 0 deletions plugins/node/instrumentation-kafkajs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"repository": "open-telemetry/opentelemetry-js-contrib",
"scripts": {
"test": "mocha --require @opentelemetry/contrib-test-utils 'test/**/*.test.ts'",
"test-all-versions": "tav",
"tdd": "npm run test -- --watch-extensions ts --watch",
"clean": "rimraf build/*",
"lint": "eslint . --ext .ts",
Expand Down Expand Up @@ -52,6 +53,7 @@
"nyc": "15.1.0",
"rimraf": "5.0.10",
"sinon": "15.2.0",
"test-all-versions": "6.1.0",
"typescript": "4.4.4"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-kafkajs/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen

const module = new InstrumentationNodeModuleDefinition(
'kafkajs',
['>=0.1.0 <3'],
['>=0.3.0 <3'],
(moduleExports: typeof kafkaJs) => {
unpatch(moduleExports);
this._wrap(
Expand Down