chore(instr-kafkajs): add missing dev-dep #2765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#2758 added
test-all-versionsdependency in thepackage.jsonfile ofkafkajsinstrumentation.However the
package-lock.jsonfile in root was not updated. So now PRs make a change whenevernpm installis ran. The 1st problem is that since the change is in rootnx affectedconsiderd that all packages are affected the unit tests run for all packages instead of only the modified ones.Short description of the changes
npm intstallpackage-lock.jsonNOTE: I wonder if it's possible to add a guard in CI for this case.