Skip to content

Conversation

@david-luna
Copy link
Contributor

Which problem is this PR solving?

#2758 added test-all-versions dependency in the package.json file of kafkajs instrumentation.

However the package-lock.json file in root was not updated. So now PRs make a change whenever npm install is ran. The 1st problem is that since the change is in root nx affected considerd that all packages are affected the unit tests run for all packages instead of only the modified ones.

Short description of the changes

  • checkout main
  • run npm intstall
  • push package-lock.json

NOTE: I wonder if it's possible to add a guard in CI for this case.

@david-luna david-luna requested a review from a team as a code owner March 19, 2025 17:04
@trentm trentm merged commit 7f48564 into open-telemetry:main Mar 19, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.51%. Comparing base (5837997) to head (6652167).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2765   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files         166      166           
  Lines        8020     8020           
  Branches     1533     1533           
=======================================
  Hits         7259     7259           
  Misses        761      761           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants