Skip to content

chore(host-metrics): do not diag.warn if using default options #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 2 commits into from
Mar 20, 2025
Merged

chore(host-metrics): do not diag.warn if using default options #2767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d1b39
chore(host-metrics): do not diag.warn if using default options
trentm Mar 19, 2025
2728051
Merge branch 'main' into tm-no-log-warn-for-default-opts-to-host-metrics
pichlermarc Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/opentelemetry-host-metrics/src/BaseMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ export abstract class BaseMetrics {
// Do not use `??` operator to allow falling back to default when the
// specified name is an empty string.
this._name = config?.name || DEFAULT_NAME;
if (config?.meterProvider == null) {
this._logger.warn('No meter provider, using default');
}
const meterProvider = config?.meterProvider ?? metrics.getMeterProvider();
this._meter = meterProvider.getMeter(this._name, PACKAGE_VERSION);
}
Expand Down