Skip to content

Conversation

@unflxw
Copy link
Contributor

@unflxw unflxw commented Mar 20, 2025

The latest version of the auto-instrumentation package is only compatible with 2.x/0.2xx versions. Update the README accordingly.

The latest version of the auto-instrumentation package is only compatible with 2.x/0.2xx versions. Update the README accordingly.
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (67e37b7) to head (7f4e682).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2768   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files         168      168           
  Lines        8078     8078           
  Branches     1548     1548           
=======================================
  Hits         7315     7315           
  Misses        763      763           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pichlermarc pichlermarc merged commit e0fa929 into open-telemetry:main Mar 20, 2025
20 checks passed
@unflxw
Copy link
Contributor Author

unflxw commented Mar 20, 2025

@pichlermarc No prob! Outside the scope of this PR, but, are there plans to bring the versioning scheme of contrib in line with what the main repo is doing? (0.2xx for experimental, 2.x for non-experimental)

@pichlermarc
Copy link
Member

Outside the scope of this PR, but, are there plans to bring the versioning scheme of contrib in line with what the main repo is doing? (0.2xx for experimental, 2.x for non-experimental)

We've not made any plans to do this at this time. I can see that this could be helpful for troubleshooting though. 🤔
It's somewhat difficult to do for contrib since all the packages are all independently versioned. They would quickly diverge again. Also not all packages break compatibility with 1.x - only resource detectors, span-processors and the metapackages are actually broken. Instrumentations and propagators will continue to work, albeit with dropped support for older Node.js and TypeScript versions.

@unflxw
Copy link
Contributor Author

unflxw commented Mar 20, 2025

Instrumentations and propagators will continue to work

Oh, that's interesting. I assumed that the bump to @opentelemetry/[email protected] in the instrumentation's dependencies meant that support for 1.x was dropped.

@pichlermarc
Copy link
Member

Instrumentations and propagators will continue to work

Oh, that's interesting. I assumed that the bump to @opentelemetry/[email protected] in the instrumentation's dependencies meant that support for 1.x was dropped.

Hmm, yes it's kind of a complex topic. 😅

Technically no two experimental versions of @opentelemetry/instrumentation are expected to be compatbile with each other as according to semver these are to be treated as if they were different major versions (hence the need to make @opentelemetry/instrumentation ready). In reality, it does happen only every once in a while that @opentelemetry/instrumentation introduces a breaking change that is actually breaking in real world use. 0.200.0 was not such a change and registerInstrumentations from the old instrumentation package should still work with instrumentations that are based on the new one.

Also since all of the instrumentation packages interact don't interact with the SDK directly, but rather with the @opentelemetry/api package (which did not receive a major version bump) nothing is technically broken for them. This is the original intention of the @opentelemetry/api package (and the API/SDK split in the specification): the SDK setup and behavior can change without breaking instrumentation code. 🙂

deejay1 pushed a commit to deejay1/opentelemetry-js-contrib that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants