Skip to content

Conversation

@anuraaga
Copy link
Contributor

Which problem is this PR solving?

  • README is not up-to-date with code

Short description of the changes

  • Updates supported versions in nestjs README

#2685 added support for NestJS 11 and I can confirm the latest released artifact works fine with it, so this updates the README to reflect it. I wasn't sure if it's better to remove <YY for YY that don't exist yet or keep it to not "pre-support" new major versions, let me know which is better.

@anuraaga anuraaga requested a review from a team as a code owner April 14, 2025 02:02
@github-actions github-actions bot added pkg:instrumentation-nestjs-core pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Apr 14, 2025
@anuraaga anuraaga changed the title Update nestjs supported versions chore(nestjs): update nestjs supported versions Apr 14, 2025
@anuraaga anuraaga changed the title chore(nestjs): update nestjs supported versions chore(instrumentation-nestjs): update nestjs supported versions Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (e88ca9d) to head (6d6d39b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2790   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files         174      174           
  Lines        8319     8319           
  Branches     1592     1592           
=======================================
  Hits         7442     7442           
  Misses        877      877           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@anuraaga
Copy link
Contributor Author

@neilime Updated this and I think just accidentally forgot to update the readme. I understand the sentiment about maintenance but does it make sense to go ahead and merge this @david-luna?

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anuraaga 🙂

#2685 added support for NestJS 11 and I can confirm the latest released artifact works fine with it, so this updates the README to reflect it. I wasn't sure if it's better to remove <YY for YY that don't exist yet or keep it to not "pre-support" new major versions, let me know which is better.

Not pre-supporting is better - we do this to avoid breaking end users on new major versions.

@pichlermarc pichlermarc merged commit a5b059d into open-telemetry:main Apr 14, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:instrumentation-nestjs-core pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants