-
Notifications
You must be signed in to change notification settings - Fork 619
feat(instrumentation-aws-sdk): add Bedrock InvokeModelWithResponseStream instrumentation #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trentm
merged 17 commits into
open-telemetry:main
from
yuliia-fryshko:bedrock-invoke-model-stream
Oct 8, 2025
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e9ae8b8
feat: add Bedrock InvokeModelWithResponseStream instrumentation
yuliia-fryshko da2cbfa
refactor: unify InvokeModel pre-span hooks into a single function wit…
yuliia-fryshko 0a80410
Moved static functions out of the method
yuliia-fryshko ff59f72
added instrumentation for Bedrock Response Stream of llama, cohere an…
yuliia-fryshko f7bbec1
added tests for cohere, cohere-r and mistral
yuliia-fryshko 44a3dec
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko 4e8b39e
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko 945df2c
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko 451c95d
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko 0fa5a4a
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko efda112
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko 6eb6eca
Merge branch 'main' into bedrock-invoke-model-stream
pichlermarc 80d93e3
close span if a chunk cannot be parsed
yuliia-fryshko 74736da
Merge branch 'main' into bedrock-invoke-model-stream
yuliia-fryshko ee6f51e
if cannot 'parseChunk' for telemetry processing, then skip adding tel…
trentm 5ac99f3
Merge branch 'main' into bedrock-invoke-model-stream
trentm 35143a4
this file was accidentally added in this feature branch
trentm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuliia-fryshko
nit: If, for whatever reason, a chunk cannot be parsed for adding otel data, should we perhaps continue to yield the chunks and eventually span.end() rather than
return;here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it will be better to close the span in this case. Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your change in commit 80d93e3 is not correct. It would result in
span.end()being called and then an attempt to callBedrockRuntimeServiceExtension.record*Attributes(...)which would likely break.I've change it to what I think it should be in commit ee6f51e.
@yuliia-fryshko Please let me know if my change looks inappropriate.