Skip to content

test(instrumentation-bunyan): update semconv usage to ATTR_ exports #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-luna merged 2 commits into from
May 23, 2025
Merged

test(instrumentation-bunyan): update semconv usage to ATTR_ exports #2847

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0ef58
test(instrumentation-bunyan): update semconv usage to ATTR_ exports
trentm May 22, 2025
16ea489
Merge branch 'main' into trentm-semconv-up-instr-bunyan
david-luna May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
import { isWrapped } from '@opentelemetry/instrumentation';
import { resourceFromAttributes } from '@opentelemetry/resources';
import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
import * as assert from 'assert';
import * as sinon from 'sinon';
import { Writable } from 'stream';
Expand All @@ -47,7 +47,7 @@ tracerProvider.register();
const tracer = tracerProvider.getTracer('default');

const resource = resourceFromAttributes({
[SEMRESATTRS_SERVICE_NAME]: 'test-instrumentation-bunyan',
[ATTR_SERVICE_NAME]: 'test-instrumentation-bunyan',
});
const loggerProvider = new LoggerProvider({ resource });
const memExporter = new InMemoryLogRecordExporter();
Expand Down