Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Jun 27, 2025

This adds lint:examples to the npm run lint that is run in CI. It does add 30s (on my machine) to the time to run npm run lint.

Refs: #2891

@trentm trentm self-assigned this Jun 27, 2025
@trentm trentm requested a review from a team as a code owner June 27, 2025 18:02
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (4386262) to head (f81a9f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
- Coverage   89.07%   89.02%   -0.05%     
==========================================
  Files         188      188              
  Lines        9223     9223              
  Branches     1900     1900              
==========================================
- Hits         8215     8211       -4     
- Misses       1008     1012       +4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag
Copy link
Contributor

maryliag commented Jul 7, 2025

is it on this PR that you can also remove the no-plusplus comments?

@trentm
Copy link
Contributor Author

trentm commented Jul 16, 2025

is it on this PR that you can also remove the no-plusplus comments?

Yup, I think I've done that. E.g. https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2919/files#diff-9e4bcffd7dfe7072133a9ccd7f1ed71b5cd2d65b71dcf5d7c4c1791a6586e385L76 is one of them.

@trentm trentm requested a review from maryliag July 16, 2025 16:30
@trentm trentm merged commit 74ddb1e into open-telemetry:main Jul 16, 2025
20 checks passed
@trentm trentm deleted the trentm-lint-examples-finale branch July 16, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants