-
Notifications
You must be signed in to change notification settings - Fork 596
feat(redis): add support for redis v5 #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redis): add support for redis v5 #2950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number in README.md needs updating as well 🙏
5f502a6
to
494563b
Compare
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (67.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
- Coverage 89.81% 89.52% -0.29%
==========================================
Files 192 192
Lines 9638 9677 +39
Branches 1988 2009 +21
==========================================
+ Hits 8656 8663 +7
- Misses 982 1014 +32
🚀 New features to boost your workflow:
|
Would be great to get this merged :) |
@blumamir any chance you can get this on your review queue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this does not follow the guidance at https://github.com/open-telemetry/semantic-conventions/tree/main/docs/database
Specifically, the environment variable opt-in mechanism for new semconv breaking changes
We are all rooting for this PR to be merged soon 😅 |
…elated to redis client connect with error handling in redis v4-v5
I think the coverage issue arises because different Redis versions (v2-v3 and v4-v5) use separate code paths and tests for each version are run independently (v2-v3 and v4-v5 have distinct sets of tests) and this can lead to incorrect coverage report, which is why the codecov/patch failed. |
Yup, exactly. Don't worry about the codecov failing check. Part of the coming work in #2866 will change to getting coverage data for multiple target module versions using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thank you for working on this.
Added few nits which can be nice to address (but not blocker for merge)
Which problem is this PR solving?
redis
v5 #2830Short description of the changes