Skip to content

chore(instr-undici): use tsup for cjs,esm output #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(instr-undici): use tsup for cjs,esm output #2954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dbc52d
chore: use tsup for cjs,esm output
david-luna Jul 23, 2025
7313a50
Merge branch 'main' into poc-esm-output-tsup
david-luna Jul 24, 2025
2dd1f5c
chore: fix compilation cache
david-luna Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ build/Release
node_modules/
jspm_packages/
build/
dist/

# TypeScript v1 declaration files
typings/
Expand Down
3 changes: 2 additions & 1 deletion nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
"{projectRoot}/test/**/*.ts"
],
"outputs": [
"{projectRoot}/build"
"{projectRoot}/build",
"{projectRoot}/dist"
Comment on lines +25 to +26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we need both build and dist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because I couldn't find an option to change the destination dir in tsup. So for now nx needs to cache build and dist. If we move forward with this all packages will have the compilation output to dist so the bukd folder will disappear from this config.

]
},
"watch": {
Expand Down
Loading
Loading