Skip to content

Conversation

tlindhardt
Copy link

Which problem is this PR solving?

  • During the upgrade of our project from v2 to v3 I noticed that the span name was not correct and the attributes were missing. Upon further inspection I found that the instrumentation was being skipped entirely.

Short description of the changes

  • Switched to ATTR_HTTP_ROUTE from SEMATTRS_HTTP_ROUTE
  • Add support to instrumentation-koa for koa v3
  • Updated tests
    • This includes removing a test to validate the generator middleware is skipped as that is no longer supported and mentioned in the upgrade guide

@tlindhardt tlindhardt requested a review from a team as a code owner July 23, 2025 21:21
Copy link

linux-foundation-easycla bot commented Jul 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added pkg:instrumentation-koa pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jul 23, 2025
@tlindhardt tlindhardt force-pushed the feat/instrumentation-koa/koa3-support branch from b499b4b to bdcd88a Compare July 23, 2025 21:33
@tlindhardt
Copy link
Author

I wasn't sure of the release process and if I needed to also change the manifest file or not.

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@dyladan
Copy link
Member

dyladan commented Aug 6, 2025

@seemk @JacksonWeber are either of you interested in becoming component owner here?

@tlindhardt tlindhardt force-pushed the feat/instrumentation-koa/koa3-support branch from 6239a33 to 1e36d6a Compare August 20, 2025 15:38
@tlindhardt tlindhardt force-pushed the feat/instrumentation-koa/koa3-support branch from 1e36d6a to 487143e Compare August 20, 2025 15:41
@tlindhardt
Copy link
Author

I went ahead and applied the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:instrumentation-koa pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants