chore(instrumentation-fastify): drop unused devDep @types/express

[trentm]

For some background, in #1804 the @types/express dep was removed from instr-express's dependencies after some long discussion. At the time it was moved to a devDep.

However, @types/express isn't used at all in these packages. Can we drop them?
Or is there some slight downside for possible IDE completion when developing express examples or similar in this repo by removing these?

Note that I only bothered looking at these because of this bot PR to update these deps: #2925 (comment)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.79%. Comparing base (96d1cbb) to head (d5dd6c6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
+ Coverage   89.53%   89.79%   +0.25%     
==========================================
  Files         183      188       +5     
  Lines        8985     9295     +310     
  Branches     1867     1907      +40     
==========================================
+ Hits         8045     8346     +301     
- Misses        940      949       +9     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

[david-luna]

In @opentelemetry/instrumentation-express the types are used internally

So the compilation step should fail if the types are not present. But if we list where the dependency is

npm ls @types/express
[email protected] /Users/david/Documents/repos/otel/opentelemetry-js-contrib
├─┬ @opentelemetry/[email protected] -> ./packages/instrumentation-express
│ └── @types/[email protected]
├─┬ @opentelemetry/[email protected] -> ./packages/instrumentation-fastify
│ └── @types/[email protected] deduped
└─┬ @opentelemetry/[email protected] -> ./packages/instrumentation-koa
  └─┬ @types/[email protected]
    └─┬ @types/[email protected]
      └── @types/[email protected] deduped

We can see that we get the express types as a dependency from @types/koa so the editor and the compiler can see them because they are installed at the root level. That would explain why compilation succeeds.

IMHO removing @types/express from @opentelemetry/instrumentation-fastify is okay but we should keep them for @opentelemetry/instrumentation-express. @opentelemetry/instrumentation-koa is unlikely to change but there is the possibility @types/koa gets an update that removes the dependency.

[trentm]

In @opentelemetry/instrumentation-express the types are used internally

Thanks! Updated.

[david-luna]

Thanks for working on this :)