feat(instrumentation-aws-lambda): support streaming handlers #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
msonnb
changed the title
JacksonWeber
reviewed
Aug 5, 2025
| this._endSpan(span, undefined, () => resolve(value)) | ||
| ); | ||
| }, | ||
| (err: Error | string) => { |
There was a problem hiding this comment.
Is it intentional that the promise fails silently in this scenario?
There was a problem hiding this comment.
I'm not fully sure what you mean 🤔 we return a new promise that rejects with the error after the span is ended, so it shouldn't fail silently? (Also I didn't change this part, just extracted it into a function)
|
cc @jj22ee (component owner) |
|
Hey, thanks for the fix. Planning to take a look this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2827
Short description of the changes
Adds support for AWS Lambda streaming handlers by checking if the handler has the special
aws.lambda.runtime.handler.streamingsymbol.