feat(instrumentation-amqp): adds stable semantic conventions #2976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, the
amqplib
instrumentation only exports legacy attributes.However, according to the OpenTelemetry specifications, we will have to migrate to new attributes to ensure better compatibility and consistency across tools and libraries.
The v1.36.0+ conventions are not yet stable but will become stable in the future, so I think it's important to begin implementing the export of these new attributes, in order to anticipate the deprecation of the legacy ones, improve interoperability with other tools, and align with community best practices.
Short description of the changes
Adds support for stable semantic conventions in the amqplib instrumentation, controlled by the
OTEL_SEMCONV_STABILITY_OPT_IN=messaging
environment variable.Key changes:
I used these specifications for implementing new attributes:
Migration guide
When upgrading to the new semantic conventions, it is recommended to follow this migration path:
@opentelemetry/instrumentation-amqplib
to the latest versionOTEL_SEMCONV_STABILITY_OPT_IN=messaging/dup
to emit both old and new semantic conventionsOTEL_SEMCONV_STABILITY_OPT_IN=messaging
to emit only the new semantic conventions