Skip to content

Conversation

lukeina2z
Copy link
Contributor

This PR adds the aws.step_functions.activity.arn and aws.step_functions.state_machine.arn semantic convention attributes for the following AWS resources:

AWS Step Functions SDK

The ARNs are extracted from request objects, and this behavior is covered by unit tests.

Tests Run:
npm run compile
npm run lint
npm run test

All newly added tests pass, and no regressions were found.

Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.

Which problem is this PR solving?

Short description of the changes

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (1d263e5) to head (d244e8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2977      +/-   ##
==========================================
+ Coverage   89.53%   89.55%   +0.02%     
==========================================
  Files         192      193       +1     
  Lines        9679     9698      +19     
  Branches     2009     2011       +2     
==========================================
+ Hits         8666     8685      +19     
  Misses       1013     1013              
Files with missing lines Coverage Δ
packages/instrumentation-aws-sdk/src/semconv.ts 100.00% <100.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 97.36% <100.00%> (+0.30%) ⬆️
...trumentation-aws-sdk/src/services/stepfunctions.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukeina2z lukeina2z force-pushed the sfns-pr-real branch 5 times, most recently from eb7ac1c to 71ba1f2 Compare August 13, 2025 19:33
@lukeina2z lukeina2z force-pushed the sfns-pr-real branch 2 times, most recently from 122ea5c to 0d2e856 Compare August 26, 2025 21:55
@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label Aug 27, 2025
…nctions

This PR adds the aws.step_functions.activity.arn and aws.step_functions.state_machine.arn semantic convention attributes for the following AWS resources:

AWS Step Functions SDK

The ARNs are extracted from request objects, and this behavior is covered by unit tests.

Tests Run:
npm run compile
npm run lint
npm run test

All newly added tests pass, and no regressions were found.

Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for messing up the merge earlier.
looks good 👍

@pichlermarc pichlermarc enabled auto-merge (squash) August 27, 2025 17:36
@lukeina2z
Copy link
Contributor Author

sorry for messing up the merge earlier. looks good 👍

Not a problem at all. Thank you for your time looking into this.

@pichlermarc pichlermarc merged commit c7a91fc into open-telemetry:main Aug 27, 2025
25 checks passed
@dyladan dyladan mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants