-
Notifications
You must be signed in to change notification settings - Fork 596
feat(instrumentation-aws-sdk): Add semconv attributes for AWS Step Functions #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8416e56
to
0502f1e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
+ Coverage 89.53% 89.55% +0.02%
==========================================
Files 192 193 +1
Lines 9679 9698 +19
Branches 2009 2011 +2
==========================================
+ Hits 8666 8685 +19
Misses 1013 1013
🚀 New features to boost your workflow:
|
eb7ac1c
to
71ba1f2
Compare
71ba1f2
to
c7996b2
Compare
122ea5c
to
0d2e856
Compare
…nctions This PR adds the aws.step_functions.activity.arn and aws.step_functions.state_machine.arn semantic convention attributes for the following AWS resources: AWS Step Functions SDK The ARNs are extracted from request objects, and this behavior is covered by unit tests. Tests Run: npm run compile npm run lint npm run test All newly added tests pass, and no regressions were found. Backward Compatibility: This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.
befea74
to
d244e8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for messing up the merge earlier.
looks good 👍
Not a problem at all. Thank you for your time looking into this. |
This PR adds the aws.step_functions.activity.arn and aws.step_functions.state_machine.arn semantic convention attributes for the following AWS resources:
AWS Step Functions SDK
The ARNs are extracted from request objects, and this behavior is covered by unit tests.
Tests Run:
npm run compile
npm run lint
npm run test
All newly added tests pass, and no regressions were found.
Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.
Which problem is this PR solving?
Short description of the changes