-
Notifications
You must be signed in to change notification settings - Fork 596
feat(opentelemetry-instrumentation-aws-lambda): Add sqs context propagation #2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(opentelemetry-instrumentation-aws-lambda): Add sqs context propagation #2981
Conversation
Converted this back to draft PR. Some stuff I need to figure out first. Used the sqs instrumentation from the aws sdk instrumentation package as an example but there are a bunch of deprecated semconv attributes. |
…ll. And fallback to message attribute value if stringValue is undefined
e0722a0
to
69c3ef1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
+ Coverage 89.83% 89.85% +0.01%
==========================================
Files 188 188
Lines 9288 9311 +23
Branches 1905 1912 +7
==========================================
+ Hits 8344 8366 +22
- Misses 944 945 +1
🚀 New features to boost your workflow:
|
… determine if it is an sqs event
…tions spec for messaging spans
@jj22ee Any thoughts on this PR? There's some use of deprecated semconv attributes for the messaging spans. But these only have alternatives that are still incubating currently. So I believe we would prefer the deprecated ones to avoid possibly breaking on minor version updates for these semconv attributes? Also, there's currently still a bunch of separate commits not adhering to the conventional commits standard. Is it expected that I rebase and squash the commits myself? Or is this done eventually on merge? |
Can this be merged, please? |
Hey, planning to take a look this week. |
Which problem is this PR solving?
#2921 No SQS Context propagation in aws lambda.
Short description of the changes
Used pubsub propagation utils to automatically created processing spans for each sqs record within a lambda sqs event. These spans link to their producer span, as is described in the spec: https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#consumer-spans