chore: pin our selected typescript version (5.0.4) to the top-level node_modules install to reduce duplication #2988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2856
(
feat(deps): lock file maintenance) "decided" to move[email protected]up to the top-level./node_modules/...and move themuch more common
[email protected](the version we intentionally haveall published packages depend on) into the package-specific subdirs
(e.g.
./packages/{subdir}/node_modules/typescript).This resulted in (a) a much bigger working copy after
npm ci(895M -> 3.7G!) and (b) a "WARNING" of unsupported typescript version
from running 'npm run lint' in a package dir.
See slack thread with some details: https://cloud-native.slack.com/archives/C08T7MZTV8W/p1754064934133129
I also have a theory (without too much evidence) that this could be contributing to CI being slow: the
build-and-cachestep in unit-test.yml has a WHOLE LOT MO build to cache.