Skip to content

test: test-all-versions in parallel #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

test: test-all-versions in parallel #2994

wants to merge 3 commits into from

Conversation

@Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented Aug 21, 2025 •
edited
Loading

Which problem is this PR solving?

Speeding up testing all versions by running them in parallel.

Short description of the changes

Patch tav to install packages differently.

@Ugzuzg Ugzuzg requested a review from a team as a code owner August 21, 2025 19:18
Ugzuzg
Ugzuzg commented Sep 4, 2025
View reviewed changes
test-all-versions.js Outdated
Copy link
Contributor Author

@Ugzuzg Ugzuzg Sep 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-luna, apart from some flaky mongodb tests which fail under stress (and some undici tests that I've fixed already), this tav patch seems to be working and offers a 2x speedup. I'll check with tav maintainers what they think of this approach, and if it's possible to upstream.

Copy link
Contributor

@david-luna david-luna Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ugzuzg

thanks! I think for now we can rely on npm run --workspaces and revisit this if upstreamed.

Copy link
Contributor Author

@Ugzuzg Ugzuzg Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mongodb test failures were caused by the missing callback. Now, everything seems to be working!

Copy link
Contributor

@david-luna david-luna Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! is the assignment of process.env.npm_config_legacy_peer_deps the only difference from upstream?

Copy link
Contributor Author

@Ugzuzg Ugzuzg Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it also isolates the installs from each other by creating synthetic packages outside the scope of the npm monorepo and then linking the installed packages into the node_modules of the specific npm "workspace".

watson/test-all-versions#26

@Ugzuzg Ugzuzg force-pushed the nx-tav branch 4 times, most recently from 6933bdd to 71b88ef Compare September 4, 2025 18:42
@Ugzuzg Ugzuzg changed the title test: trying out nx tav parallel patch test: test-all-versions in parallel Sep 4, 2025
@david-luna david-luna mentioned this pull request Sep 5, 2025
Merged
@Ugzuzg Ugzuzg mentioned this pull request Sep 5, 2025
Closed
@Ugzuzg Ugzuzg force-pushed the nx-tav branch 4 times, most recently from ac2f4d2 to f3104df Compare September 11, 2025 16:26
@Ugzuzg Ugzuzg force-pushed the nx-tav branch 8 times, most recently from 7b9d99f to 86b819f Compare September 19, 2025 18:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

This issue was closed because no owner or sponsor has been found after 14 days

@github-actions github-actions bot closed this Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-luna david-luna david-luna left review comments

Assignees

@david-luna david-luna

@maryliag maryliag

@obecny obecny

@d4nyll d4nyll

@blumamir blumamir

@naseemkullah naseemkullah

@mottibec mottibec

@JamieDanielson JamieDanielson

@mhennoch mhennoch

@jj22ee jj22ee

Labels

pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-kafkajs pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-openai pkg:instrumentation-oracledb pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-undici pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.