Skip to content

fix: fix test-all-versions script #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

fix: fix test-all-versions script #3017

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6467a18
fix: fix test-all-versions script
david-luna Sep 4, 2025
8a90ea4
chore: leftovers in test workflow
david-luna Sep 4, 2025
3bc5538
chore: add mssing flags to avoid cleanup of coverage
david-luna Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ jobs:
- "20"
- "22"
- "24"
include:
- node: 18
code-coverage: true
runs-on: ubuntu-latest
services:
memcached:
Expand Down Expand Up @@ -273,6 +270,11 @@ jobs:
with:
name: tests-coverage-cache-${{ github.run_number }}-22
path: .
- name: Download Test Artifacts (24)
uses: actions/download-artifact@v5
with:
name: tests-coverage-cache-${{ github.run_number }}-24
path: .
# Note: see comment in the compile job
- name: Set base and head commits
run: |
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@
"version:update": "nx run-many -t version:update",
"compile": "nx run-many -t compile",
"compile:ci:affected": "nx affected -t compile",
"list:affected": "nx affected -t test-all-versions --graph=stdout | jq -c '.tasks.tasks[].target.project'",
"test": "nx run-many -t test",
"test:ci:affected": "nx affected -t test",
"test:browser": "nx run-many -t test:browser",
"test:browser:ci:affected": "nx affected -t test:browser",
"test-all-versions": "nx run-many --parallel=false -t test-all-versions",
Copy link
Contributor

@Ugzuzg Ugzuzg Sep 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nx sets process.env.npm_config_legacy_peer_deps = true, which messes with installation in tav. I had to unset it in the tav patch to make everything work. Could also affect regular tav installs.

"test-all-versions:ci:affected": "nx affected --parallel=false -t test-all-versions",
"test-all-versions": "npm run --if-present test-all-versions --workspaces",
"test-all-versions:ci:affected": "npm run list:affected | tail -n +5 | xargs -I {} -t npm run --if-present test-all-versions -w {}",
"test-merge-coverage:ci:affected": "nx affected -t test-merge-coverage",
"test-services:start": "docker compose -f ./test/docker-compose.yaml up -d --wait",
"test-services:stop": "docker compose -f ./test/docker-compose.yaml down",
Expand Down
1 change: 1 addition & 0 deletions packages/instrumentation-aws-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"tdd": "npm run test -- --watch-extensions ts --watch",
"test": "nyc mocha --require '@opentelemetry/contrib-test-utils' 'test/**/*.test.ts'",
"test-all-versions": "tav",
"test-merge-coverage": "nyc merge .nyc_output coverage/coverage-final.json",
"version:update": "node ../../scripts/version-update.js",
"watch": "tsc -w"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/instrumentation-cucumber/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
"directory": "packages/instrumentation-cucumber"
},
"scripts": {
"test": "nyc mocha 'test/**/*.test.ts'",
"test": "nyc --no-clean mocha 'test/**/*.test.ts'",
"test-all-versions": "tav",
"test-merge-coverage": "nyc merge .nyc_output coverage/coverage-final.json",
"tdd": "npm run test -- --watch-extensions ts --watch",
"clean": "rimraf build/*",
"lint": "eslint . --ext=ts,js,mjs",
Expand Down
1 change: 1 addition & 0 deletions packages/instrumentation-ioredis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"prepublishOnly": "npm run compile",
"test": "nyc --no-clean mocha 'test/**/*.test.ts'",
"test-all-versions": "tav",
"test-merge-coverage": "nyc merge .nyc_output coverage/coverage-final.json",
"tdd": "npm run test -- --watch-extensions ts --watch",
"test:debug": "cross-env RUN_REDIS_TESTS=true mocha --inspect-brk --no-timeouts 'test/**/*.test.ts'",
"test:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm test",
Expand Down
3 changes: 2 additions & 1 deletion packages/instrumentation-mongoose/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
"test-v5-v6": "nyc mocha --require '@opentelemetry/contrib-test-utils' 'test/mongoose-common.test.ts' 'test/**/mongoose-v5-v6.test.ts'",
"test-v7-v8": "nyc mocha --require '@opentelemetry/contrib-test-utils' 'test/mongoose-common.test.ts' 'test/**/mongoose-v7-v8.test.ts'",
"test:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm test",
"test-all-versions": "tav",
"test-all-versions": "tav",
Copy link
Contributor

@trentm trentm Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
"test-all-versions": "tav",
"test-all-versions": "tav",

"test-all-versions:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm run test-all-versions",
"test-merge-coverage": "nyc merge .nyc_output coverage/coverage-final.json",
"test-services:start": "cd ../.. && npm run test-services:start mongodb",
"test-services:stop": "cd ../.. && npm run test-services:stop mongodb",
"version:update": "node ../../scripts/version-update.js"
Expand Down
3 changes: 2 additions & 1 deletion packages/instrumentation-pg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@
"lint:readme": "node ../../scripts/lint-readme.js",
"prepublishOnly": "npm run compile",
"tdd": "npm run test -- --watch-extensions ts --watch",
"test": "nyc mocha 'test/**/*.test.ts'",
"test": "nyc --no-clean mocha 'test/**/*.test.ts'",
"test:debug": "mocha --inspect-brk --no-timeouts 'test/**/*.test.ts'",
"test:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm test",
"test-all-versions": "tav",
"test-all-versions:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm run test-all-versions",
"test-merge-coverage": "nyc merge .nyc_output coverage/coverage-final.json",
"test-services:start": "cd ../.. && npm run test-services:start postgres",
"test-services:stop": "cd ../.. && npm run test-services:stop postgres",
"version:update": "node ../../scripts/version-update.js",
Expand Down
1 change: 1 addition & 0 deletions packages/instrumentation-redis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"test:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm test",
"test-all-versions": "tav",
"test-all-versions:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm run test-all-versions",
"test-merge-coverage": "nyc merge .nyc_output coverage/coverage-final.json",
"test-services:start": "cd ../.. && npm run test-services:start redis",
"test-services:stop": "cd ../.. && npm run test-services:stop redis",
"version:update": "node ../../scripts/version-update.js"
Expand Down
Loading