Skip to content

Conversation

@overbalance
Copy link
Contributor

@overbalance overbalance commented Sep 5, 2025

Which problem is this PR solving?

  • Locally I was unable to pass npm run test if the db service was not started.

Short description of the changes

  • I copied the guard from the regular test to the ESM version. I have no prior experience with the db packages so please close this if it's off base.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (a50cb61) to head (b3be5d5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3023   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         146      146           
  Lines        8192     8192           
  Branches     1846     1846           
=======================================
  Hits         7491     7491           
  Misses        701      701           
Flag Coverage Δ
instrumentation-pg 95.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and thanks for adding the missing code! 😄

@maryliag maryliag enabled auto-merge (squash) September 5, 2025 17:26
@maryliag
Copy link
Contributor

maryliag commented Sep 5, 2025

@overbalance for some reason is not showing me the option to update with the main before merging, would you mind updating with the latest from main so I can merge it? thanks

auto-merge was automatically disabled September 5, 2025 21:50

Head branch was pushed to by a user without write access

@overbalance overbalance force-pushed the overbalance/skip-pg-test branch from 1d5749b to b3be5d5 Compare September 5, 2025 21:50
@overbalance overbalance requested a review from maryliag September 8, 2025 06:09
@pichlermarc pichlermarc merged commit f8e623e into open-telemetry:main Sep 8, 2025
26 of 27 checks passed
@overbalance overbalance deleted the overbalance/skip-pg-test branch September 8, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants