Skip to content

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Oct 8, 2025

One complication was that in [email protected] interface ChatCompletionMessageToolCall
was changed to be:

    export type ChatCompletionMessageToolCall =
      | ChatCompletionMessageFunctionToolCall
      | ChatCompletionMessageCustomToolCall;

which complicated capturing 'tool_calls' info for the telemetry event.

Note also that the GenAI semconv has since moved on. As of open-telemetry/semantic-conventions#2179
there is no longer a 'tool_calls' property in a captured event. This PR
does not get into updating the semconv version used by this instrumentation.

Unrelated, there was also a fix to a typo in the 'compile:with-dependencies' npm script
for this package.

One complication was that in [email protected] 'interface ChatCompletionMessageToolCall'
was changed to be:
    export type ChatCompletionMessageToolCall =
      | ChatCompletionMessageFunctionToolCall
      | ChatCompletionMessageCustomToolCall;
which complicated capturing 'tool_calls' info for the telemetry event.

Note also that the GenAI semconv has since moved on. As of open-telemetry/semantic-conventions#2179
there is no longer a 'tool_calls' property in a captured event. This PR
does *not* get into updating the semconv version used by this instrumentation.

Unrelated, there was also a fix to a typo in the 'compile:with-dependencies' npm script
for this package.
@trentm trentm self-assigned this Oct 8, 2025
@trentm trentm requested a review from a team as a code owner October 8, 2025 21:38
@github-actions github-actions bot requested a review from seemk October 8, 2025 21:38
@trentm trentm enabled auto-merge (squash) October 9, 2025 14:13
@trentm trentm merged commit 7ffc32f into open-telemetry:main Oct 9, 2025
9 checks passed
@trentm trentm deleted the trentm-openai-6 branch October 9, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants