Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

Which problem is this PR solving?

  • Decreases the amount of updates needing approval for pr to be created

Short description of the changes

  • restrict dashboard approval for minor updates to js packages
  • Auto create pr for minor updates to all non js dependencies
  • Auto create pr for major updates to ci dependencies

All pr's are following existing scheduled time.

@thompson-tomo thompson-tomo requested a review from a team as a code owner November 20, 2025 14:04
@thompson-tomo thompson-tomo changed the title Update renovate.json to include matchManagers rules infra: Update renovate.json to include matchManagers rules Nov 20, 2025
@thompson-tomo thompson-tomo changed the title infra: Update renovate.json to include matchManagers rules ci: Update renovate.json to include matchManagers rules Nov 20, 2025
@pichlermarc pichlermarc self-assigned this Dec 3, 2025
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine either way: (a) politely declining this change (I could help more looking at the dashboard issue) or (b) limiting the dependencyDashboardApproval: true guard to just npm deps.

If doing (b) I assume we'd want similar for the opentelemetry-js.git repo to keep the renovate somewhat in sync between the two repos.

I totally defer to @pichlermarc as he is doing most of the good work of dealing with renovate PRs.

},
{
"matchUpdateTypes": ["minor"],
"matchManagers": ["js"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct but js is the category name https://docs.renovatebot.com/modules/manager/ hence encompasses other js package sources.

"schedule": ["before 3am on Monday"]
},
{
"matchManagers": ["ci"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but category is ci https://docs.renovatebot.com/modules/manager/ hence a little more broad.

@trentm
Copy link
Contributor

trentm commented Dec 3, 2025

@thompson-tomo Is there a particular issue you are trying to resolve? Is this mainly about trying to get quicker updates to the github-actions uses: ... lines under .github/workflows?

@thompson-tomo
Copy link
Contributor Author

Correct it is about getting ci environment updates quicker and removing the need for them to be approved to be created leading to smaller queue to review.

Option b is what this pr does, scopes the approval step to just javascript packages ie npm.

Yes I am more than happy to sync this change with the non contrib repo after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants