-
Notifications
You must be signed in to change notification settings - Fork 619
ci: Update renovate.json to include matchManagers rules #3233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
trentm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine either way: (a) politely declining this change (I could help more looking at the dashboard issue) or (b) limiting the dependencyDashboardApproval: true guard to just npm deps.
If doing (b) I assume we'd want similar for the opentelemetry-js.git repo to keep the renovate somewhat in sync between the two repos.
I totally defer to @pichlermarc as he is doing most of the good work of dealing with renovate PRs.
| }, | ||
| { | ||
| "matchUpdateTypes": ["minor"], | ||
| "matchManagers": ["js"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the manager name is npm (https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/api.ts#L72).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct but js is the category name https://docs.renovatebot.com/modules/manager/ hence encompasses other js package sources.
| "schedule": ["before 3am on Monday"] | ||
| }, | ||
| { | ||
| "matchManagers": ["ci"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I believe this one is 'github-actions', https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/api.ts#L155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but category is ci https://docs.renovatebot.com/modules/manager/ hence a little more broad.
|
@thompson-tomo Is there a particular issue you are trying to resolve? Is this mainly about trying to get quicker updates to the github-actions |
|
Correct it is about getting ci environment updates quicker and removing the need for them to be approved to be created leading to smaller queue to review. Option b is what this pr does, scopes the approval step to just javascript packages ie npm. Yes I am more than happy to sync this change with the non contrib repo after approval. |
Which problem is this PR solving?
Short description of the changes
All pr's are following existing scheduled time.