feat(instrumentation-aws-lambda): add runtime-aware handler support for Node.js 24 compatibility #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Removed support for callback-based Lambda handlers. Only Promise-based handlers (async/await or functions returning Promises) are now supported. This aligns with AWS Lambda's deprecation of callbacks in Node.js 24 runtime. Changes: - Removed Callback import and _wrapCallback method from instrumentation - Updated patchedHandler to only accept (event, context) parameters - Converted all test handlers from callback-based to Promise-based - Updated all tests to use Promise-based handlers directly - Added migration guide in README.md - Documented breaking change in CHANGELOG.md All 50 tests passing.
…ith backward compatibility Added runtime-aware handler support that automatically detects Node.js version from AWS_EXECUTION_ENV and adapts handler signatures accordingly. Node.js 24+ only supports Promise-based handlers, while Node.js 22 and lower support both callback and Promise-based handlers for backward compatibility.
maxday
reviewed
Nov 26, 2025
Member
maxday
left a comment
maxday
left a comment
There was a problem hiding this comment.
Thanks @RaphaelManke
I left minor comments, feel free to ignore
- Refactor getNodeRuntimeVersion() to isSupportingCallbacks() returning boolean - Default to false (no callbacks) when AWS_EXECUTION_ENV is not set - Update README example to use ESM syntax for Promise-based handler
trentm
reviewed
Nov 26, 2025
| }; | ||
|
|
||
| exports.stringerror = function (event, context, callback) { | ||
| exports.callbackstringerror = async function (event, context) { |
Contributor
There was a problem hiding this comment.
nit: I suppose the "callback" name in this test fixture is a bit out of place now.
Contributor
Author
There was a problem hiding this comment.
yeah this is a leftover from an intermediate state. Deleted it as its covered in another test
Member
|
Confirming it's working fine by
was failing before, succeeding with this change |
- Remove duplicate callbackstringerror handler (same as stringerror) - Remove callbackStringError test (strings are not valid for Lambda callbacks) - Update test to use stringerror instead of callbackstringerror
RaphaelManke
force-pushed
the
remove-lambda-callback-support
branch
from
59f0dae to
3564271
Compare
trentm
approved these changes
Nov 26, 2025
|
|
||
| exports.callbackerror = function (event, context, callback) { | ||
| callback(new Error('handler error')); | ||
| exports.callbackerror = async function (event, context) { |
Contributor
There was a problem hiding this comment.
nit: have exports.callbackerror and exports.callbackError :) This one here is currently a bit misleading. Minor though.
Contributor
|
Thank you for your contribution @RaphaelManke! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #3251 by adding runtime-aware handler support that automatically detects the Node.js version from
AWS_EXECUTION_ENVand adapts handler signatures accordingly.Fixes: #3251
Problem
AWS Lambda deprecated callback-based handlers in Node.js 24 runtime, causing the instrumentation to fail with:
Solution
The instrumentation now automatically detects the Node.js runtime version and adapts:
(event, context)- no callback parameter (respects AWS deprecation)(event, context, callback?)- supports both callback and Promise-based handlers for backward compatibilityI tested it by building a lambda layer with this code version.
Changes
getNodeRuntimeVersion()function to detect Node.js version fromAWS_EXECUTION_ENVenvironment variable_wrapCallback()method for callback support on older runtimesTesting
Backward Compatibility
This change maintains full backward compatibility:
Related Links