fix(instrumentation-pg): normalize leading/trailing spaces in database operation name #3270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR intends to solves bug #3265.
Removing leading and trailing whitespaces when parsing and extracting the command from query text.
Actual Behavior:
When calling get query span name with leading spaces in the query text, the spaces are translated into the Span
e.g
utils.getQuerySpanName('dbName', { text: ' SELECT $1' })results inpg.query: SELECT dbNameIntended Behavior
Leading spaces are removed
utils.getQuerySpanName('dbName', { text: ' SELECT $1' })results inpg.query: SELECT dbNameShort description of the changes
Offtopic and other notes
While reviewing other modules also found that
packages/instrumentation-mysql/src/utils.tsandpackages/instrumentation-mysql2/src/utils.tsuse similar methods that may need revision.