feat(instrumentation-nats): add instrumentation nats package#3352
Draft
giacomoquinalia wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
feat(instrumentation-nats): add instrumentation nats package#3352giacomoquinalia wants to merge 2 commits intoopen-telemetry:mainfrom
giacomoquinalia wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
02dcdd5 to
f69d05e
Compare
Author
|
A better approach for the instrumentation was suggested by a NATS maintainer in this issue and I'll update the implementation of this PR once the native support is available in the core library. |
Member
|
Would you mind converting this to a draft in the meantime or closing and reopening ? This would help in making it easier to sort through GH notifications for approvers :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Initial instrumentation for NATS.
Short description of the changes
This is a continuation of the initiative started in this PR: #667. The implementation follows the architectural considerations and feedback discussed in that PR, especially the insights shared by NATS maintainers (referencing this maintainer comment).
This implementation follows the patterns and structures used in existing messaging instrumentations like kafkajs and amqplib.
Testing
The implementation has been tested locally and is functioning as expected.
Feedback
While the implementation is stable in my test environment, I would appreciate validation from the maintainers and the community: