feat(pg): add pg-pool.release span#3364
Open
MUSKANNISHAD wants to merge 1 commit intoopen-telemetry:mainfrom
Open
feat(pg): add pg-pool.release span#3364MUSKANNISHAD wants to merge 1 commit intoopen-telemetry:mainfrom
MUSKANNISHAD wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Author
|
I’ve added tracing for pg-pool.release by wrapping client.release() on the client returned from pool.connect(). This captures the full pool lifecycle while keeping metrics unchanged. I’ve opened a PR for review. |
Contributor
|
please add tests to validate your changes |
3e3a878 to
a61b987
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1976
This PR adds a
pg-pool.releasespan by instrumentingclient.release()on theclient returned from
pool.connect().This allows tracing the full PostgreSQL pool lifecycle
(connect → query → release) while keeping existing pool metrics behavior unchanged.