fix(instrumentation-pg): correct db.client.connection.count metric counting to handle multiple pg pools#3367
Draft
trentm wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
Conversation
…counting to handle multiple pg pools Before this change the instrumentation was assuming there was only ever one active PG pool. Fixes: open-telemetry#3354
trentm
commented
Jan 29, 2026
| let connCount = connCountFromPoolName[poolName]; | ||
| if (!connCount) { | ||
| connCount = {used: 0, idle: 0, pending: 0}; | ||
| connCountFromPoolName[poolName] = connCount; |
Contributor
Author
There was a problem hiding this comment.
A concern here is that connCountFromPoolName will grow for every new PG poolName. Entries are never removed from this mapping.
In normal usage I would think an app would only ever have one or a few PG pools. If this is a concern, we could use something like an LRU cache (e.g. https://github.com/isaacs/node-lru-cache, or https://github.com/isaacs/ttlcache).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the instrumentation was assuming there was only ever
one active PG pool.
Fixes: #3354
Checklist
db.namespacecould include the PG schema, if any. Though really this would be a separate PR.