feat(instrumentation-mongoose): Support v9#3368
Open
Farhan-Abbas wants to merge 2 commits intoopen-telemetry:mainfrom
Open
feat(instrumentation-mongoose): Support v9#3368Farhan-Abbas wants to merge 2 commits intoopen-telemetry:mainfrom
Farhan-Abbas wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
e9929df to
64576c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3285. This PR adds support for mongoose@9 to the
@opentelemetry/instrumentation-mongoosepackage.Short description of the changes
Breaking Changes
None. The core instrumentation code itself required no changes - only version ranges were updated to
<10.However, Mongoose@9's internal changes required some changes to our tests and the TypeScript configuration.
Here's a quick summary of all the changes:
Version Range Updates
>=5.9.7 <9to>=5.9.7 <10in:src/mongoose.ts(instrumentation module definition)README.md(documentation)package.json(devDependencies updated to mongoose@9.1.5)Testing Configuration
mongoose-v7-v8.test.ts→mongoose-v7-v9.test.tstest-v7-v8→test-v7-v9in package.jsonTypeScript Compatibility
skipLibCheck: trueto handle mongoose@9's excessively deep type instantiation issues (TS2589)Test Adjustments
Document.prototype.updateOne()test - mongoose@9 returns empty objects for condition/updates/options in the serialized statement for document-level operationsas anytype assertion to updateOne test to avoid TypeScript errors