feat(instrumentation-undici): support "QUERY" as a known HTTP method#3374
Open
trentm wants to merge 1 commit intoopen-telemetry:mainfrom
Open
feat(instrumentation-undici): support "QUERY" as a known HTTP method#3374trentm wants to merge 1 commit intoopen-telemetry:mainfrom
trentm wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
QUERY is (or soon will be, I'm not sure what is "authoritative" here) an accepted HTTP request method. See https://datatracker.ietf.org/doc/draft-ietf-httpbis-safe-method-w-body/ FWIW, "QUERY" was added to the set of values for the `http.request.method` enum in semconv v1.38.0 recently. Refs: open-telemetry/semantic-conventions#2642 Refs: open-telemetry/opentelemetry-js#6160 (same change for instrs in core repo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUERY is (or soon will be, I'm not sure what is "authoritative" here) an
accepted HTTP request method. See https://datatracker.ietf.org/doc/draft-ietf-httpbis-safe-method-w-body/
FWIW, "QUERY" was added to the set of values for the
http.request.methodenum in semconv v1.38.0.Refs: open-telemetry/semantic-conventions#2642
Refs: open-telemetry/opentelemetry-js#6160 (same change for instrs in core repo)
This is a follow-up of the same change made to instr-http et al in the core repo in November.