-
Notifications
You must be signed in to change notification settings - Fork 978
feat(core)!: remove unused/obsolete functions and types #5444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pichlermarc
merged 2 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/core-unused-functions-types
Feb 11, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,11 +16,7 @@ | |
|
|
||
| export { W3CBaggagePropagator } from './baggage/propagation/W3CBaggagePropagator'; | ||
| export { AnchoredClock, Clock } from './common/anchored-clock'; | ||
| export { | ||
| isAttributeKey, | ||
| isAttributeValue, | ||
| sanitizeAttributes, | ||
| } from './common/attributes'; | ||
| export { isAttributeValue, sanitizeAttributes } from './common/attributes'; | ||
| export { | ||
| globalErrorHandler, | ||
| setGlobalErrorHandler, | ||
|
|
@@ -40,32 +36,14 @@ export { | |
| millisToHrTime, | ||
| timeInputToHrTime, | ||
| } from './common/time'; | ||
| export { | ||
| ErrorHandler, | ||
| InstrumentationScope, | ||
| ShimWrapped, | ||
| TimeOriginLegacy, | ||
| } from './common/types'; | ||
| export { hexToBinary } from './common/hex-to-binary'; | ||
| export { ErrorHandler, InstrumentationScope } from './common/types'; | ||
| export { ExportResult, ExportResultCode } from './ExportResult'; | ||
| import { | ||
| getKeyPairs, | ||
| serializeKeyPairs, | ||
| parseKeyPairsIntoRecord, | ||
| parsePairKeyValue, | ||
| } from './baggage/utils'; | ||
| export const baggageUtils = { | ||
| getKeyPairs, | ||
| serializeKeyPairs, | ||
| parseKeyPairsIntoRecord, | ||
| parsePairKeyValue, | ||
| }; | ||
| export { parseKeyPairsIntoRecord } from './baggage/utils'; | ||
| export { | ||
| SDK_INFO, | ||
| _globalThis, | ||
| getEnv, | ||
| getEnvWithoutDefaults, | ||
| hexToBase64, | ||
| otperformance, | ||
| unrefTimer, | ||
| } from './platform'; | ||
|
|
@@ -105,9 +83,7 @@ export { | |
| export { merge } from './utils/merge'; | ||
| export { TimeoutError, callWithTimeout } from './utils/timeout'; | ||
| export { isUrlIgnored, urlMatches } from './utils/url'; | ||
| export { isWrapped } from './utils/wrap'; | ||
| export { BindOnceFuture } from './utils/callback'; | ||
| export { VERSION } from './version'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no way to read the |
||
| import { _export } from './internal/exporter'; | ||
| export const internal = { | ||
| _export, | ||
|
|
||
21 changes: 0 additions & 21 deletions
21
packages/opentelemetry-core/src/platform/browser/hex-to-base64.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ export { | |
| _globalThis, | ||
| getEnv, | ||
| getEnvWithoutDefaults, | ||
| hexToBase64, | ||
| otperformance, | ||
| unrefTimer, | ||
| } from './node'; | ||
20 changes: 0 additions & 20 deletions
20
packages/opentelemetry-core/src/platform/node/hex-to-base64.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
packages/opentelemetry-core/test/platform/hex-to-base64.test.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in a comment, this is used in one contrib package (
plugin-react-load). So perhaps this falls under:It is used in tests in another package (
opentelemetry-instrumentation-user-interaction), but that pkg also has a dep on@opentelemetry/instrumentation, so can use theisWrappedfrom there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks for double checking - I had missed that one. I've opened a PR to make all necessary changes in contrib: open-telemetry/opentelemetry-js-contrib#2704
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since both implementations are identical I've opted to just use the one from
@opentelemetry/instrumentationinstead. :)