Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Feb 11, 2025

This adds the same lint step added to the contrib repo in
open-telemetry/opentelemetry-js-contrib#2569
It ensures that the semantic-conventions dep is being used
as recommended: no usage of incubating, no pinning of the dep.


If this had been run before the recent #5446 the lint output would have been:

% npm run lint:semconv-deps
lint-semconv-deps error: experimental/packages/web-common/src/SessionSpanProcessor.ts: uses the 'incubating' entry-point from '@opentelemetry/semantic-conventions', but should not (see https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv)
lint-semconv-deps error: experimental/packages/web-common/src/SessionLogRecordProcessor.ts: uses the 'incubating' entry-point from '@opentelemetry/semantic-conventions', but should not (see https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv)

This adds the same lint step added to the contrib repo in
open-telemetry/opentelemetry-js-contrib#2569
It ensures that the semantic-conventions dep is being used
as recommended: no usage of incubating, no pinning of the dep.
@trentm trentm self-assigned this Feb 11, 2025
@trentm trentm requested a review from a team as a code owner February 11, 2025 23:47
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (4fb9c5a) to head (aaa7fab).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         309      309           
  Lines        7967     7967           
  Branches     1678     1678           
=======================================
  Hits         7551     7551           
  Misses        416      416           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc added this pull request to the merge queue Feb 12, 2025
Merged via the queue into open-telemetry:main with commit fcd96de Feb 12, 2025
18 of 19 checks passed
trentm added a commit to trentm/opentelemetry-js that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants