Closed
Conversation
Pulls in changes from the first prototype and applies them to the 2.0 SDK TODO: tests, entity detectors
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (25.89%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5620 +/- ##
==========================================
- Coverage 95.17% 94.27% -0.91%
==========================================
Files 316 317 +1
Lines 8521 8625 +104
Branches 1763 1789 +26
==========================================
+ Hits 8110 8131 +21
- Misses 411 494 +83
🚀 New features to boost your workflow:
|
…pentelemetry-js into res-prototype-v2
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
- Add asyncAttributesPending and waitForAsyncAttributes to Entity type - Implement forEntity in TracerProvider interface - Implement forEntity in BasicTracerProvider to create provider with merged entity - Implement forEntity in NoopTracerProvider (returns self) - Implement forEntity in ProxyTracerProvider with entity property support - Update all test mocks to include forEntity method
- Store MeterProviderOptions in _config field for forEntity implementation - Implement forEntity to create new MeterProvider with entity added to resource
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in changes from the first prototype and applies them to the 2.0 SDK
TODO:
Entitya type/interface instead of a class because it is accessed fromresource.entitiesOpen questions: