fix(instrumentation): change SemconvStability export from const enum to enum
#5692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…um` to `enum` to allow single-file transpilation tooling to work with code that uses `SemconvStability` Refs: open-telemetry#5691 Refs: open-telemetry/opentelemetry-js-contrib#2671 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5692 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 310 310
Lines 7992 7992
Branches 1614 1614
=======================================
Hits 7595 7595
Misses 397 397 🚀 New features to boost your workflow:
|
maryliag
approved these changes
May 16, 2025
JamieDanielson
approved these changes
May 16, 2025
Member
JamieDanielson
left a comment
JamieDanielson
left a comment
There was a problem hiding this comment.
thank you for grabbing this so quickly!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
SemconvStabilityexport fromconst enumtoenumto allow single-file transpilation tooling to work with code that usesSemconvStabilityRefs: #5691
Refs: open-telemetry/opentelemetry-js-contrib#2671 (comment)