-
Notifications
You must be signed in to change notification settings - Fork 946
feat(sampler-composite): add experimental implementation of composite sampling spec #5839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
33485d3
feat(trace): add experimental implementation of draft consistent samp…
anuraaga 0a967ac
Update changelog
anuraaga 1fbc1dc
git add
anuraaga 0f1d33e
Drift
anuraaga b41131b
Fix folder name
anuraaga 38ecc13
Fix
anuraaga acc3070
Cleanup
anuraaga 63c6c06
Rename package
anuraaga 3119308
README
anuraaga a6df902
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 2b5e7c5
Cleanup
anuraaga 7ced0a5
Factory functions
anuraaga 7f7afdc
Doc
anuraaga 47c3fd4
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 61656b5
Hard refresh lock
anuraaga 861ac86
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 6592630
Cleanup
anuraaga 98e5cd8
Update CHANGELOG.md
anuraaga b7a34e6
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga fd5c24a
Merge branch 'consistent-sampling' of https://github.com/anuraaga/ope…
anuraaga af4bc3e
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 00a00f9
Force merge package lock
anuraaga 02c8bce
Add precision TODO
anuraaga 04809a3
Finish
anuraaga ffc9bc4
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
anuraaga 21ad9dc
Update experimental/CHANGELOG.md
trentm 535292e
Merge branch 'main' into consistent-sampling
trentm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[This is a general question. I'm commenting here for lack of a good place to mention it.]
My head is spinning from the inconsistent (har har) use of
CompositeorComposableorConsistentusage in class and interface names in the spec, OTEP, and implementations. And also, a little less so, in some class name changes, e.g.ConsistentFixedThresholdin the OTEP vs.ComposableTraceIDRatioBasedin the spec. I haven't read through this PR yet, but I'm guessing other API diffs between OTEP and spec will show up, e.g.threshold_reliablein the spec vs.IsAdjustedCountReliablein the OTEP.While I don't know that the names used in the spec need to be the same names as in the implementation APIs, approaching the same names is likely desired. Are we implementing the spec here, or the Java
consistent56implementation, which seems to follow the OTEP naming (which makes sense as it was probably developed before the spec renamings)?I'm happy to go asking about this in the OTel channels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I will read the spec and align with it as much as possible, sorry for missing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what Java (and the Rust/Go implementations that are linked to from open-telemetry/opentelemetry-specification#4466) will do. I.e. will they change their implementations to use the class names in the spec? Or change the spec to use
Consistent-prefix?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the rust and go implementations (esp. the go implementation README: https://github.com/jmacd/go-sampler) I'm pretty certain
CompositeSamplerandComposable*Samplernaming is the intent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for clarification in #otel-sampling: https://cloud-native.slack.com/archives/C027DS6GZD3/p1755299016130699
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue/answer on the naming: open-telemetry/opentelemetry-specification#4640
Basically: "So the short answer is that the Specification names should be used.", but "do not strongly believe that all SDKs need the same exact names".
So, whatever names are used by a particular SDK is fine.
(Note that I would expect the OTel schema for its configuration data model would use the spec names for these samplers, when these new samplers are added to the schema. At that point there is some value to users and maintainers if the configuration names match the implementation names.)