-
Notifications
You must be signed in to change notification settings - Fork 946
feat(opentelemetry-configuration): Parse of Configuration File #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5875 +/- ##
==========================================
+ Coverage 95.10% 95.14% +0.03%
==========================================
Files 315 316 +1
Lines 8396 8457 +61
Branches 1727 1747 +20
==========================================
+ Hits 7985 8046 +61
Misses 411 411
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to get to this one - I'll have a look at the second one soon.
experimental/packages/opentelemetry-configuration/src/configModel.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
…igProvider.ts Co-authored-by: Marc Pichler <[email protected]>
|
Note the lint failure here with linkinator failing (in |
… sampling spec (open-telemetry#5839) Co-authored-by: Trent Mick <[email protected]>
…omposite sampling spec (open-telemetry#5839)" This reverts commit a662970.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments - after these, this is good to merge 🙂
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Show resolved
Hide resolved
|
@pichlermarc all comments addressed, let me know if you want any other changes |
Part Of #5813
Parse a yaml/yml file and populate the corresponding parameters on config model
Parse of remaining items can be done once #5862 is merged