Skip to content

Conversation

@maryliag
Copy link
Contributor

Part Of #5813
Parse a yaml/yml file and populate the corresponding parameters on config model

Parse of remaining items can be done once #5862 is merged

@maryliag maryliag requested a review from a team as a code owner August 22, 2025 15:48
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (0d8f4af) to head (dd72027).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5875      +/-   ##
==========================================
+ Coverage   95.10%   95.14%   +0.03%     
==========================================
  Files         315      316       +1     
  Lines        8396     8457      +61     
  Branches     1727     1747      +20     
==========================================
+ Hits         7985     8046      +61     
  Misses        411      411              
Files with missing lines Coverage Δ
...try-configuration/src/EnvironmentConfigProvider.ts 98.93% <100.00%> (-0.02%) ⬇️
...ntelemetry-configuration/src/FileConfigProvider.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-configuration/src/configModel.ts 100.00% <ø> (ø)
.../packages/opentelemetry-configuration/src/utils.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this one - I'll have a look at the second one soon.

@trentm
Copy link
Contributor

trentm commented Sep 19, 2025

Note the lint failure here with linkinator failing (in npm run docs:test): see #5839 (comment)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments - after these, this is good to merge 🙂

@maryliag
Copy link
Contributor Author

@pichlermarc all comments addressed, let me know if you want any other changes

@pichlermarc pichlermarc added this pull request to the merge queue Sep 23, 2025
Merged via the queue into open-telemetry:main with commit b11baa1 Sep 23, 2025
25 checks passed
@maryliag maryliag deleted the config-yml branch September 23, 2025 13:35
@otelbot-js otelbot-js bot mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants