-
Notifications
You must be signed in to change notification settings - Fork 936
feat(otlp-exporter-base)!: allow passing an async function to headers option #5994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pichlermarc
wants to merge
8
commits into
open-telemetry:main
Choose a base branch
from
dynatrace-oss-contrib:feat/dynamic-headers-http
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(otlp-exporter-base)!: allow passing an async function to headers option #5994
pichlermarc
wants to merge
8
commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/dynamic-headers-http
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5994 +/- ##
=======================================
Coverage 94.99% 95.00%
=======================================
Files 313 314 +1
Lines 8775 8780 +5
Branches 1884 1885 +1
=======================================
+ Hits 8336 8341 +5
Misses 439 439
🚀 New features to boost your workflow:
|
fb742e6
to
2eb5cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Implements dynamic headers for the HTTP-based exporters. The current internal implementation was already prepared for synchronous dynamic headers. A synchronous approach had two downsides that would've just limited its usefulness to end-users:
import
calls were impossible to use. Delaying the loading of any libraries so that the can be instrumented, was only possible in CJS, not ESM.To circumvent these issues, this PR makes the internal function used to obtain headers
async
and also allows the end-user to pass it to the exporter. There is still some potential of this feature being a footgun due to possible load-order issues, however, with the approach from this PR we can provide guidance on how to do this safely without causing issues. If needed, we can also provide a utility class to reduce friction later.Almost all of the code was already tested since #5179 switched to factory functions internally to prepare for this change (see coverage report on this PR). These tests simply changed in this PR from sync to async.
Other potential issues not tackled in this PR:
401
or403
so one HAS to do proactive token refresh.401
and403
be retryable. I've opted not to do this right now as I'd like to see if the current solution is "good enough"Closes #5756
Closes #2903