Skip to content

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

Add generation script that generates types based on the otel config schema, using a tool called quicktype. These types are intended to be used in the configuration package instead of us handrolling the types.

I haven't gone through this enough yet to see how accurate it is and if it fits our needs or requires more tuning (it very likely requires more tuning).

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Ran the script and confirmed generated types were created

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (af28dba) to head (9e8b772).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6001      +/-   ##
==========================================
- Coverage   95.23%   95.22%   -0.01%     
==========================================
  Files         311      311              
  Lines        8596     8603       +7     
  Branches     1799     1801       +2     
==========================================
+ Hits         8186     8192       +6     
- Misses        410      411       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag
Copy link
Contributor

maryliag commented Oct 9, 2025

Nice! one suggestion for checking your results: look at this latest PR I created: #6000
The majority of models are added on it, and I separated by file, like the schema, to make things easier to compare, organize, etc, so it would be good if this also generated like that

@maryliag
Copy link
Contributor

maryliag commented Oct 9, 2025

There is also a file that has the description of the parameters, so you should also combine that, so we know more info, default values, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate configuration model from schema spec

2 participants