-
Notifications
You must be signed in to change notification settings - Fork 953
feat(opentelemetry-config): set headers from headers_list #6060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(opentelemetry-config): set headers from headers_list #6060
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6060 +/- ##
==========================================
- Coverage 95.16% 95.10% -0.07%
==========================================
Files 316 316
Lines 9207 9231 +24
Branches 2075 2079 +4
==========================================
+ Hits 8762 8779 +17
- Misses 445 452 +7
🚀 New features to boost your workflow:
|
| }, | ||
| ], | ||
| }, | ||
| tracer_provider: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, you will just need more tests. It's hard to get tests for all possible options, it takes some work 😓
|
I'm holding off on adding the last bit of tests because there are some pretty major merge conflicts with the other changes 😅 If these don't get added into the other PRs, I'll update this after the others merge. |
|
oops, I'mm not making your life easier with all my changes 😅 |
Which problem is this PR solving?
Set headers from headers_list if headers doesn't exist
Short description of the changes
Set headers from headers_list if headers doesn't exist
Type of change
How Has This Been Tested?
Checklist: