feat(instrumentation): add createInstrumentation factory function
#6163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
this PR add a factory function to create instrumentations. the factory function has a single param to get an object that implements the
InstrumentationDelegateinterface. The factory function wraps the delegate and takes care of the enabling or disabling the instrumentation (interaction with RITM and ITM).This approach removes the inheritance from
InstrumentationAbstract -> InstrumentationBaseavoiding any initialisation issue in the constructor as it happens in #1989.with this change we will have two ways of creating instrumentations:
InstrumentationBasecreateInstrumentationfunction with a delegateIMHO the path should be to sunset the former in favour of the later so we avoid the init issue in all instrumentations and also simplifies a bit the instrumentation code.
Fixes #1989
Short description of the changes
createInstrumentationin instrumentation package for nodecreateInstrumentationin instrumentation package for browserHttpInstrumentationDelegateclass and exportcreateHttpInstrumentationfunction in http instrumentationType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
http-delegate-*.test.tsfilesChecklist: