feat: add httpsprovider #1601
Merged
feat: add httpsprovider #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serkan-ozal
reviewed
Nov 19, 2024
Adds the [httpsprovider](https://github.com/open-telemetry/opentelemetry-collector/tree/main/confmap/provider/httpsprovider) to also support `https://` as scheme in `OPENTELEMETRY_COLLECTOR_CONFIG_URI`.
theSuess
force-pushed
the
feat/add-httpsprovider
branch
from
da3fb17 to
020ff55
Compare
serkan-ozal
approved these changes
Nov 20, 2024
pragmaticivan
approved these changes
Nov 29, 2024
Member
pragmaticivan
left a comment
pragmaticivan
left a comment
There was a problem hiding this comment.
LGTM (although worth keeping an eye on increase of latency on cold start)
Member
|
Also worth checking this PR https://github.com/open-telemetry/opentelemetry-lambda/pull/1277/files more changes missing? (maybe close this older pr) |
vasireddy99
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the httpsprovider to also support
https://as scheme inOPENTELEMETRY_COLLECTOR_CONFIG_URI.