feat(nodejs): add ability to be able to enable/disable active instrumentations by env var #1653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea to give more control of what is loaded and what not. This change seems to introduce a configuration option (unless it's just something experimental/internal right now) and therefore should have a documentation section in the readme. |
Contributor
Author
|
These configurations are already in use ones as mentioned here: https://opentelemetry.io/docs/zero-code/js/configuration/#excluding-instrumentation-libraries |
serkan-ozal
force-pushed
the
feat/nodejs/enable-disable-instrumentations
branch
2 times, most recently
from
6a87508 to
9a82902
Compare
Member
|
It looks like Node already follows this convention, so that's fine. Just pointing it out that Java does it a bit differently: https://opentelemetry.io/docs/zero-code/java/agent/disable/#enable-only-specific-instrumentation |
…entations by env var
serkan-ozal
force-pushed
the
feat/nodejs/enable-disable-instrumentations
branch
from
9a82902 to
af819a8
Compare
mpuigdomenchSage
pushed a commit
to Sage/opentelemetry-lambda
that referenced
this pull request
Jan 28, 2025
…entations by env var (open-telemetry#1653) * feat(nodejs): add ability to be able to enable/disable active instrumentations by env var
DivMode
added a commit
to DivMode/opentelemetry-lambda
that referenced
this pull request
Nov 3, 2025
…L_NODE_DISABLED_INSTRUMENTATIONS Extends PR open-telemetry#1653 to make AWS-specific instrumentations (aws-lambda, aws-sdk) also respect the OTEL_NODE_DISABLED_INSTRUMENTATIONS environment variable. Previously, these instrumentations were always loaded regardless of the disable flag. Now they follow the same conditional loading pattern as other instrumentations. Fixes: Users can now disable AWS Lambda auto-instrumentation in dev mode
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.